refactor: extract path resolution and directory creation helpers #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0364bf5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Oct 26, 2025
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Oct 26, 2025
Collaborator
Author
This was referenced Oct 26, 2025
pranaygp
force-pushed
the
pranaygp/extract-path-helpers
branch
from
93750d8 to
bfd4924
Compare
pranaygp
force-pushed
the
pranaygp/add-builder-type-safety
branch
from
21d8ce1 to
87c62d3
Compare
adriandlam
approved these changes
Nov 1, 2025
pranaygp
force-pushed
the
pranaygp/add-builder-type-safety
branch
from
87c62d3 to
41b3842
Compare
pranaygp
force-pushed
the
pranaygp/extract-path-helpers
branch
from
bfd4924 to
7254323
Compare
pranaygp
force-pushed
the
pranaygp/add-builder-type-safety
branch
from
43397b2 to
3e05dc7
Compare
pranaygp
force-pushed
the
pranaygp/extract-path-helpers
branch
from
4294532 to
cbd8775
Compare
TooTallNate
force-pushed
the
pranaygp/add-builder-type-safety
branch
from
3e05dc7 to
07674c6
Compare
…nions Improves type safety by creating discriminated union types for builder-specific configurations, making it clear which configuration options are required for each builder type. Changes: - Created BaseWorkflowConfig interface with common options - Created StandaloneConfig, VercelBuildOutputConfig, and NextConfig types - Made WorkflowConfig a discriminated union based on buildTarget - Added documentation for each configuration type - Exported new types from @workflow/builders This enables better IntelliSense and type checking when constructing builder configurations, preventing invalid configuration combinations at compile time. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Adds reusable helper methods to BaseBuilder for common path operations,
reducing code duplication and improving readability in builder subclasses.
Changes:
- Added resolvePath() helper in BaseBuilder
- Added ensureDirectory() helper in BaseBuilder
- Updated StandaloneBuilder (both in @workflow/builders and @workflow/cli)
to use the new helpers
- Removed unnecessary imports from StandaloneBuilder
This simplifies path handling code from:
const path = resolve(this.config.workingDir, this.config.somePath);
await mkdir(dirname(path), { recursive: true });
To:
const path = this.resolvePath(this.config.somePath);
await this.ensureDirectory(path);
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <[email protected]>
Signed-off-by: Nathan Rajlich <[email protected]>
TooTallNate
force-pushed
the
pranaygp/extract-path-helpers
branch
from
cbd8775 to
0364bf5
Compare
TooTallNate
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds reusable helper methods to BaseBuilder for common path operations,
reducing code duplication and improving readability in builder subclasses.
Changes:
to use the new helpers
This simplifies path handling code from:
const path = resolve(this.config.workingDir, this.config.somePath);
await mkdir(dirname(path), { recursive: true });
To:
const path = this.resolvePath(this.config.somePath);
await this.ensureDirectory(path);
🤖 Generated with Claude Code
Co-Authored-By: Claude [email protected]